Avoid instance vars, setting state in LevelsHelper#get_channel_for - #15054
#15054Merged
joshlory merged 1 commit intoMay 13, 2017
stagingcode-dot-org/code-dot-org:stagingfrom
helper-instance-var-cleanupcode-dot-org/code-dot-org:helper-instance-var-cleanupCopy head branch name to clipboard
Merged
Avoid instance vars, setting state in LevelsHelper#get_channel_for#15054joshlory merged 1 commit intostagingcode-dot-org/code-dot-org:stagingfrom helper-instance-var-cleanupcode-dot-org/code-dot-org:helper-instance-var-cleanupCopy head branch name to clipboard
LevelsHelper#get_channel_for#15054joshlory merged 1 commit into
stagingcode-dot-org/code-dot-org:stagingfrom
helper-instance-var-cleanupcode-dot-org/code-dot-org:helper-instance-var-cleanupCopy head branch name to clipboard
Conversation
davidsbailey
approved these changes
May 12, 2017
davidsbailey
left a comment
Member
There was a problem hiding this comment.
Nice work Josh, I like this approach!
islemaster
approved these changes
May 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I plan to address the
readonly_view_optionsTODO in a future PR — it's pretty entangled with the view options helper.