Flip school info interstitial live - #14866
#14866Merged
ewjordan merged 3 commits intoMay 5, 2017
stagingcode-dot-org/code-dot-org:stagingfrom
school-info-interstitial-go-livecode-dot-org/code-dot-org:school-info-interstitial-go-liveCopy head branch name to clipboard
Merged
Flip school info interstitial live#14866ewjordan merged 3 commits intostagingcode-dot-org/code-dot-org:stagingfrom school-info-interstitial-go-livecode-dot-org/code-dot-org:school-info-interstitial-go-liveCopy head branch name to clipboard
ewjordan merged 3 commits into
stagingcode-dot-org/code-dot-org:stagingfrom
school-info-interstitial-go-livecode-dot-org/code-dot-org:school-info-interstitial-go-liveCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various cleanup tasks involved with actually activating the school info interstitial. Primarily this PR turns the interstitial from being flag-only tofully live, turning on the targeting logic in SchoolInfoInterstitialHelper.
Upon noticing issues with the way data was coming through to the server, though, I added tweaks to validation and parameter whitelisting (specifically, in some cases data wasn't getting saved at all, and in others it wasn't being deduplicated correctly).
There's still more to do on this feature, but in the name of getting it live in some way before the AP exam we decided to ship what we have. The primary limitation is that we are leaving alone anyone that we have useful previous data on schools for, as that version of the dialog was not testable in time.