Allow Symfony 6 and resolve depreciations#299
Allow Symfony 6 and resolve depreciations#299
Conversation
4bda1a1 to
f1ac25b
Compare
f1ac25b to
2411abf
Compare
florianeckerstorfer
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR, looks good. There is just one misplaced parenthesis that makes one test fail.
Co-authored-by: Florian Eckerstorfer <florian@eckerstorfer.net>
|
Good catch. There is issue with scrutinizer. Not sure if it is correctly configured. |
| ], | ||
| "require": { | ||
| "php": ">=7.0", | ||
| "php": ">=7.1", |
There was a problem hiding this comment.
Should probably be ^7.1 || ~8.0.0 || ~8.1.0
There was a problem hiding this comment.
Really? Isn't PHP 8.2 supposed to be compatible with PHP 8.1?
There was a problem hiding this comment.
PHP doesn't (can't) follow SemVer, but in general, the current range selector also allows for PHP 9, which is a problem.
^7.1 || ^8.0 is also acceptable, if you feel like you aren't worried about breakages in 8.2+
There was a problem hiding this comment.
I started a PR and would appreciate your input on this: #301
First, thank you for maintaining this library. I work on a project that uses it and that needs to be upgraded to Symfony 6.0.
I had to make a lot of updates in order to have tests passing. Please tell me if you prefers separated pull requests, or anything that I should change.
symfony/simple-phpunitto get polyfills for PHPUnit versions.voidreturn type)Cocur\Slugify\Tests\Bridge\Symfony\CocurSlugifyExtensionTest, to solve an errorParseError: syntax error, unexpected token "static", expecting identifier