Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: accept in-memory upload inputs#733

Open
TalLevAmi wants to merge 2 commits into
cloudinary:mastercloudinary/cloudinary_npm:masterfrom
TalLevAmi:codex/upload-binary-inputsTalLevAmi/cloudinary_npm:codex/upload-binary-inputsCopy head branch name to clipboard
Open

feat: accept in-memory upload inputs#733
TalLevAmi wants to merge 2 commits into
cloudinary:mastercloudinary/cloudinary_npm:masterfrom
TalLevAmi:codex/upload-binary-inputsTalLevAmi/cloudinary_npm:codex/upload-binary-inputsCopy head branch name to clipboard

Conversation

@TalLevAmi

Copy link
Copy Markdown
Contributor

Summary

  • allow uploader.upload() and unsigned_upload() to accept in-memory binary inputs
  • send Buffer, Uint8Array, ArrayBuffer, and Blob data directly in the multipart body instead of treating them like file paths
  • update the TypeScript declarations and uploader specs for the new supported input types

Testing

  • npm run dtslint
  • ./node_modules/.bin/eslint lib/uploader.js test/integration/api/uploader/uploader_spec.js
  • mocked local runtime validation covering Buffer, Uint8Array, ArrayBuffer, Blob, and raw buffer uploads without hitting fs.createReadStream

Notes

  • docs left unchanged because the SDK docs are maintained externally and recent repo PRs for SDK surface additions have not updated README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.