fix(params): remove needless err return

cli · BagToad · May 19, 2025 · May 7, 2025 · May 8, 2025 · May 9, 2025
commit 871671be526e7b3e40f90a5a562a5eb75136f0a6
@@ -128,10 +128,7 @@ func (e Editable) AssigneeIds(client *api.Client, repo ghrepo.Interface) (*[]str

 			// Only suppported for actor assignees.
 			if e.Assignees.ActorAssignees {
-				replaced, err = copilotReplacer.ReplaceSlice(replaced)
-				if err != nil {
-					return nil, err
-				}
+				replaced = copilotReplacer.ReplaceSlice(replaced)
 			}

 			return replaced, nil

@@ -320,22 +320,18 @@ func NewCopilotReplacer() *CopilotReplacer {
 	return &CopilotReplacer{}
 }

-func (r *CopilotReplacer) replace(handle string) (string, error) {
+func (r *CopilotReplacer) replace(handle string) string {
 	if strings.EqualFold(handle, "@copilot") {
-		return "copilot-swe-agent", nil
+		return "copilot-swe-agent"
 	}
-	return handle, nil
+	return handle
 }

 // Replace replaces usages of `@copilot` in a slice with Copilot's login.
-func (r *CopilotReplacer) ReplaceSlice(handles []string) ([]string, error) {
+func (r *CopilotReplacer) ReplaceSlice(handles []string) []string {
 	res := make([]string, len(handles))
 	for i, h := range handles {
-		var err error
-		res[i], err = r.replace(h)
-		if err != nil {
-			return nil, err
-		}
+		res[i] = r.replace(h)
 	}
-	return res, nil
+	return res
 }
@@ -233,8 +233,7 @@ func TestCopilotReplacer_ReplaceSlice(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			r := NewCopilotReplacer()
-			got, err := r.ReplaceSlice(tt.args.handles)
-			require.NoError(t, err)
+			got := r.ReplaceSlice(tt.args.handles)
 			require.Equal(t, tt.want, got)
 		})
 	}