Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: gh gist edit panic when no file in a gist - #10627

#10627
Merged
babakks merged 2 commits into
cli:trunkcli/cli:trunkfrom
phanen:fix/gist/panic-no-file-in-gistphanen/cli:fix/gist/panic-no-file-in-gistCopy head branch name to clipboard
May 28, 2025
Merged

fix: gh gist edit panic when no file in a gist#10627
babakks merged 2 commits into
cli:trunkcli/cli:trunkfrom
phanen:fix/gist/panic-no-file-in-gistphanen/cli:fix/gist/panic-no-file-in-gistCopy head branch name to clipboard

Conversation

@phanen

@phanen phanen commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Fix #10626.

@phanen
phanen requested a review from a team as a code owner March 18, 2025 06:23
@phanen
phanen requested a review from BagToad March 18, 2025 06:23
@phanen
phanen temporarily deployed to cli-automation March 18, 2025 06:23 — with GitHub Actions Inactive
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Mar 18, 2025
BagToad
BagToad previously requested changes Apr 9, 2025

@BagToad BagToad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey @phanen - thanks for opening this! ✨

Apologies for the delayed review. I think we'd like to see a test for this behavior, would you be able to add one please?

Let me know if we can answer any questions 😁

@phanen
phanen force-pushed the fix/gist/panic-no-file-in-gist branch from 560bfe8 to 40ff954 Compare April 10, 2025 12:16
@phanen

phanen commented Apr 10, 2025

Copy link
Copy Markdown
Contributor Author

@BagToad Two test added, both can fail on cli:truck and pass in this PR.

@phanen
phanen force-pushed the fix/gist/panic-no-file-in-gist branch from 40ff954 to f38f6b1 Compare April 10, 2025 15:42
@babakks
babakks self-requested a review May 20, 2025 10:37

@babakks babakks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @phanen! 🎉

It confirms with the A/C on the issue.

It looks good, but it just needs some small improvements.

Comment thread pkg/cmd/gist/edit/edit_test.go
Comment thread pkg/cmd/gist/edit/edit.go Outdated
Comment thread pkg/cmd/gist/edit/edit_test.go Outdated
@phanen
phanen force-pushed the fix/gist/panic-no-file-in-gist branch from f38f6b1 to ef267dd Compare May 28, 2025 10:02
@phanen

phanen commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

Done. @babakks

@babakks
babakks self-requested a review May 28, 2025 11:28

@babakks babakks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @phanen! 🙏

I'll make a quick commit to improve the error message, and will then merge it.

Signed-off-by: Babak K. Shandiz <babakks@github.com>
@babakks
babakks enabled auto-merge (squash) May 28, 2025 11:45
@babakks
babakks disabled auto-merge May 28, 2025 12:10
@BagToad
BagToad dismissed their stale review May 28, 2025 12:28

Dismissing my review

@babakks
babakks merged commit 19e1178 into cli:trunk May 28, 2025
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 13, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cli/cli](https://github.com/cli/cli) | minor | `v2.73.0` -> `v2.74.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>cli/cli (cli/cli)</summary>

### [`v2.74.1`](https://github.com/cli/cli/releases/tag/v2.74.1): GitHub CLI 2.74.1

[Compare Source](cli/cli@v2.74.0...v2.74.1)

#### What's Changed

-   Document support for `@copilot` in `gh [pr|issue] edit --add-assignee` and `--remove-assignee` by [@&#8203;timrogers](https://github.com/timrogers) in cli/cli#11056
-   Fix pr edit when URL is provided by [@&#8203;williammartin](https://github.com/williammartin) in cli/cli#11057
-   Fix const in MR finder tests by [@&#8203;babakks](https://github.com/babakks) in cli/cli#11091

**Full Changelog**: cli/cli@v2.74.0...v2.74.1

### [`v2.74.0`](https://github.com/cli/cli/releases/tag/v2.74.0): GitHub CLI 2.74.0

[Compare Source](cli/cli@v2.73.0...v2.74.0)

#### Security

A security vulnerability has been identified in a core `gh` dependency, `go-gh`, where an attacker-controlled GitHub Enterprise Server could result in executing arbitrary commands on a user's machine by replacing HTTP URLs provided by GitHub with local file paths for browsing.

This issue is addressed in this `gh` release by updating `go-gh` to a fixed version.

For more information, see GHSA-g9f5-x53j-h563

#### What's changed

##### ✨ Features

-   Add `preview prompter` command by [@&#8203;BagToad](https://github.com/BagToad) in cli/cli#10745
-   \[gh run watch] Support `--compact` flag by [@&#8203;iamazeem](https://github.com/iamazeem) in cli/cli#10629
-   Fix brew update notifications by [@&#8203;BagToad](https://github.com/BagToad) in cli/cli#11024

##### 🐛 Fixes

-   Revert "\[gh config] Escape pipe symbol in Long desc for website manual" by [@&#8203;BagToad](https://github.com/BagToad) in cli/cli#11004
-   Fix formatting in allowed values for `gh config --help` by [@&#8203;BagToad](https://github.com/BagToad) in cli/cli#11003
-   fix: `gh gist edit` panic when no file in a gist by [@&#8203;phanen](https://github.com/phanen) in cli/cli#10627
-   Add retry logic when fetching TUF content in `gh attestation` commands by [@&#8203;malancas](https://github.com/malancas) in cli/cli#10943

##### 📚 Docs & Chores

-   Update README.md by [@&#8203;irhdab](https://github.com/irhdab) in cli/cli#11022
-   Add tests for `RenderJobs` and `RenderJobsCompact` by [@&#8203;babakks](https://github.com/babakks) in cli/cli#11013
-   Add example usage of `--head` option to `pr list` docs by [@&#8203;babakks](https://github.com/babakks) in cli/cli#10979
-   Mention `pr create` will print the created MR's URL by [@&#8203;babakks](https://github.com/babakks) in cli/cli#10980
-   Add Digest to ReleaseAsset struct by [@&#8203;bdehamer](https://github.com/bdehamer) in cli/cli#11030

##### :dependabot: Dependencies

-   Bump `go-gh` to v2.12.1 by [@&#8203;BagToad](https://github.com/BagToad) in cli/cli#11043
-   chore(deps): bump github.com/gabriel-vasile/mimetype from 1.4.8 to 1.4.9 by [@&#8203;dependabot](https://github.com/dependabot) in cli/cli#10825
-   Update sigstore-go dependency to v1.0.0 by [@&#8203;malancas](https://github.com/malancas) in cli/cli#11028
-   chore(deps): bump github.com/sigstore/protobuf-specs from 0.4.1 to 0.4.2 by [@&#8203;dependabot](https://github.com/dependabot) in cli/cli#10999
-   chore(deps): bump github.com/yuin/goldmark from 1.7.8 to 1.7.12 by [@&#8203;dependabot](https://github.com/dependabot) in cli/cli#11032

#### New Contributors

-   [@&#8203;irhdab](https://github.com/irhdab) made their first contribution in cli/cli#11022
-   [@&#8203;phanen](https://github.com/phanen) made their first contribution in cli/cli#10627

**Full Changelog**: cli/cli@v2.73.0...v2.74.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC41MC4wIiwidXBkYXRlZEluVmVyIjoiNDAuNTAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh gist edit can panic index of range when no file in a gist

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.