-
Notifications
You must be signed in to change notification settings - Fork 8.8k
[gh issue/pr comment] Add support for last comment delete for issues and PRs #10596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
babakks
merged 19 commits into
cli:trunk
from
sinansonmez:feature/10366/issue-comment-delete-last
May 1, 2025
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
bd6c084
deletion for issues with confirmation flag
sinansonmez 1a38559
add handling for interaction case
sinansonmez 1e24644
finish implementation for issues
sinansonmez 1d8e9ef
finish the implementation for issues
sinansonmez 37b2c58
finalize the implementation for PR
sinansonmez 15ae972
fix missing --yes flag for PR
sinansonmez 184d9ec
Merge branch 'trunk' into feature/10366/issue-comment-delete-last
sinansonmez 51e50e5
address PR comments related to feedbacks
sinansonmez ee921ee
improve CommentablePreRun for pre checks
sinansonmez 241af93
Merge branch 'trunk' into feature/10366/issue-comment-delete-last
sinansonmez 7225b88
improve confirmation prompt and truncate long comment body
sinansonmez fcd5201
address PR comments on tests
sinansonmez ba857b3
Truncate comment for confirmation prompt
babakks 0361970
Improve test case descriptions
babakks 3b0fae1
Fix mock comment body
babakks f626950
Remove irrelevant prompt stub
babakks a55f8a2
Use `opts.Interactive` as TTY indicator
babakks ffabed2
Fix expected `Interactive` value
babakks 39ccaf1
Polish `TestNewCmdComment`
babakks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 clarification. The mutation mention
issuein the name. However, it works both for issues and PRs. Is it OK to use for both? Or for PRs should I use something else?