Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 6fffc2e

Browse filesBrowse files
williammartinwilliammartin
authored
Merge pull request #13254 from cli/wm/enable-telemetry
Enable telemetry without env var
2 parents b5757ea + 90ef03e commit 6fffc2e
Copy full SHA for 6fffc2e

11 files changed

+1-11Lines changed: 1 addition & 11 deletions
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎acceptance/testdata/skills/skills-install.txtar‎

Copy file name to clipboardExpand all lines: acceptance/testdata/skills/skills-install.txtar
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ grep 'github-repo' $WORK/custom-skills/git-commit/SKILL.md
2121

2222
# Telemetry: skill_install event records agent hosts, repo identifiers,
2323
# and (for a public repo) the installed skill name.
24-
env GH_PRIVATE_ENABLE_TELEMETRY=1
2524
env GH_TELEMETRY=log
2625
env GH_TELEMETRY_SAMPLE_RATE=100
2726
exec gh skill install github/awesome-copilot git-commit --scope user --force --agent github-copilot
Collapse file

‎acceptance/testdata/skills/skills-preview.txtar‎

Copy file name to clipboardExpand all lines: acceptance/testdata/skills/skills-preview.txtar
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ stderr 'not found'
1010

1111
# Telemetry: skill_preview event records repo identifiers and, for a
1212
# public repo, the skill name.
13-
env GH_PRIVATE_ENABLE_TELEMETRY=1
1413
env GH_TELEMETRY=log
1514
env GH_TELEMETRY_SAMPLE_RATE=100
1615
exec gh skill preview github/awesome-copilot git-commit
Collapse file

‎acceptance/testdata/telemetry/command-invocation.txtar‎

Copy file name to clipboardExpand all lines: acceptance/testdata/telemetry/command-invocation.txtar
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# Telemetry log mode outputs command invocation event to stderr
2-
env GH_PRIVATE_ENABLE_TELEMETRY=1
32
env GH_TELEMETRY=log
43
env GH_TELEMETRY_SAMPLE_RATE=100
54

Collapse file

‎acceptance/testdata/telemetry/no-telemetry-for-alias.txtar‎

Copy file name to clipboardExpand all lines: acceptance/testdata/telemetry/no-telemetry-for-alias.txtar
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
# resolved inner command should still record normally — its path is a core
33
# gh command and conveys no user-authored identifier.
44

5-
env GH_PRIVATE_ENABLE_TELEMETRY=1
65
env GH_TELEMETRY=log
76
env GH_TELEMETRY_SAMPLE_RATE=100
87

Collapse file

‎acceptance/testdata/telemetry/no-telemetry-for-completion.txtar‎

Copy file name to clipboardExpand all lines: acceptance/testdata/telemetry/no-telemetry-for-completion.txtar
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# The completion command should not generate a telemetry event
2-
env GH_PRIVATE_ENABLE_TELEMETRY=1
32
env GH_TELEMETRY=log
43
env GH_TELEMETRY_SAMPLE_RATE=100
54

Collapse file

‎acceptance/testdata/telemetry/no-telemetry-for-extension.txtar‎

Copy file name to clipboardExpand all lines: acceptance/testdata/telemetry/no-telemetry-for-extension.txtar
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
# organization or project name).
44
[!exec:bash] skip
55

6-
env GH_PRIVATE_ENABLE_TELEMETRY=1
76
env GH_TELEMETRY=log
87
env GH_TELEMETRY_SAMPLE_RATE=100
98

Collapse file

‎acceptance/testdata/telemetry/no-telemetry-for-ghes-user.txtar‎

Copy file name to clipboardExpand all lines: acceptance/testdata/telemetry/no-telemetry-for-ghes-user.txtar
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# GHES users should not get telemetry even when telemetry is enabled
2-
env GH_PRIVATE_ENABLE_TELEMETRY=1
32
env GH_TELEMETRY=log
43
env GH_TELEMETRY_SAMPLE_RATE=100
54
env GH_ENTERPRISE_TOKEN=fake-enterprise-token
Collapse file

‎acceptance/testdata/telemetry/no-telemetry-for-send-telemetry.txtar‎

Copy file name to clipboardExpand all lines: acceptance/testdata/telemetry/no-telemetry-for-send-telemetry.txtar
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# The send-telemetry command should not itself generate a telemetry event
2-
env GH_PRIVATE_ENABLE_TELEMETRY=1
32
env GH_TELEMETRY=log
43
env GH_TELEMETRY_SAMPLE_RATE=100
54
env GH_TELEMETRY_ENDPOINT_URL=http://localhost:1
Collapse file

‎acceptance/testdata/telemetry/telemetry-failure-does-not-break-command.txtar‎

Copy file name to clipboardExpand all lines: acceptance/testdata/telemetry/telemetry-failure-does-not-break-command.txtar
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# Command completes successfully even when telemetry endpoint is unreachable
2-
env GH_PRIVATE_ENABLE_TELEMETRY=1
32
env GH_TELEMETRY=enabled
43
env GH_TELEMETRY_SAMPLE_RATE=100
54
env GH_TELEMETRY_ENDPOINT_URL=http://localhost:1
Collapse file

‎acceptance/testdata/telemetry/telemetry-for-official-extension-stub.txtar‎

Copy file name to clipboardExpand all lines: acceptance/testdata/telemetry/telemetry-for-official-extension-stub.txtar
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
# names come from a fixed, hard-coded registry and do not contain any
44
# user-authored identifiers.
55

6-
env GH_PRIVATE_ENABLE_TELEMETRY=1
76
env GH_TELEMETRY=log
87
env GH_TELEMETRY_SAMPLE_RATE=100
98

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.