[WIP] Markush#49
Open
TimurGimadiev wants to merge 5 commits into
Open
Conversation
Member
Author
|
X atoms not implemented yet |
smiles generator fixed. removed overengineering. TODO: finish MRV and MarkushContainer.
Member
|
Partially refactored. API discussion and use cases are required! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let`t start with Markushi
As a feature u can do str(MarkushiContainer), then put it to Marvin and it will show the structure.
Then you can save mrv and parse it back to MarkushiContainer (not perfect, but work)
Looking back for comments. I know that it has copy paste code, but I think it is much more safe for the first period to avoid breaking of native classes.