fix(types): add [number, number] tuple support for line and scatter chart defaultDataPoint#12250
Open
subodhbhyri wants to merge 1 commit into
chartjs:masterchartjs/Chart.js:masterfrom
subodhbhyri:fix/tuple-data-types-12232subodhbhyri/Chart.js:fix/tuple-data-types-12232Copy head branch name to clipboard
Open
fix(types): add [number, number] tuple support for line and scatter chart defaultDataPoint#12250subodhbhyri wants to merge 1 commit intochartjs:masterchartjs/Chart.js:masterfrom subodhbhyri:fix/tuple-data-types-12232subodhbhyri/Chart.js:fix/tuple-data-types-12232Copy head branch name to clipboard
subodhbhyri wants to merge 1 commit into
chartjs:masterchartjs/Chart.js:masterfrom
subodhbhyri:fix/tuple-data-types-12232subodhbhyri/Chart.js:fix/tuple-data-types-12232Copy head branch name to clipboard
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using an array of tuples (
[number, number][]) as dataset data on alineor
scatterchart, TypeScript raises:This is despite tuples being a documented data structure
and already being supported for
barcharts via[number, number]in itsdefaultDataPoint.Fixes #12232
Changes
[number, number]todefaultDataPointforlineandscatterinsrc/types/index.d.ts, matching the existingbarchart behaviortest/types/dataset_null_data.tsandtest/types/data_types.tsto cover bothChartDatasetand fullnew Chart(...)instantiation with tuple dataScope
This PR fixes the TypeScript type error only. The runtime issue (line not
rendering when
parsing: falseis set with tuple data) is a separate problemin the data parsing pipeline and is not addressed here.