Check numpad enter for text input submissions by Jarrio · Pull Request #149 · ceramic-engine/ceramic

Jarrio · Apr 17, 2025

No description provided.

jeremyfa · Apr 17, 2025

Thanks for the PR, I'm not against that change, but the way it is done is not correct:

As with LSHIFT/RSHIFT or similar, we should not abstract away what exact key have been pressed at backend level.
If we are going for that change:
- The backend should call a new method called ceramic.App.app.textInput.kpEnter() so that we can decide what to do with it at higher level and we don't lose any information on the way
- All backends should be supported, not only clay backend. The call to kpEnter() should also be added in unity backend

jeremyfa · May 22, 2025

Changes look good now, thanks!

Update TextInput.hx

5a98c39

Jarrio added 2 commits April 17, 2025 19:14

Update TextInput.hx

b073022

Update TextInput.hx

ccd7ab8

jeremyfa force-pushed the master branch 12 times, most recently from 43f9ee1 to aeb18ef Compare May 19, 2025 12:10

jeremyfa merged commit ec212aa into ceramic-engine:master May 22, 2025

Provide feedback