Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Change default java toolchain and build from 8 to 11. Add separate CI for Java 8 builds #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Feb 27, 2025
Merged

Change default java toolchain and build from 8 to 11. Add separate CI for Java 8 builds #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 4 .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
common --noenable_bzlmod
common --enable_workspace
build --java_runtime_version=remotejdk_8
build --java_language_version=8
build --java_runtime_version=remotejdk_11
build --java_language_version=11

# Hide Java 8 deprecation warnings.
common --javacopt=-Xlint:-options
2 changes: 2 additions & 0 deletions 2 .github/workflows/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:
repository-cache: true
- name: Bazel Output Version
run: bazelisk --version
- name: Java 8 Build
run: bazel build ... --java_language_version=8 --java_runtime_version=8
- name: Bazel Test
# Exclude codelab exercises as they are intentionally made to fail
run: bazelisk test ... --deleted_packages=//codelab/src/test/codelab --test_output=errors
Expand Down
4 changes: 2 additions & 2 deletions 4 BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ default_java_toolchain(
package_configuration = [
":error_prone",
],
source_version = "8",
target_version = "8",
source_version = "11",
target_version = "11",
)

# This associates a set of javac flags with a set of packages
Expand Down
6 changes: 4 additions & 2 deletions 6 publish/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@


ALL_TARGETS=("//publish:cel.publish" "//publish:cel_compiler.publish" "//publish:cel_runtime.publish" "//publish:cel_v1alpha1.publish" "//publish:cel_protobuf.publish")
JDK8_FLAGS="--java_language_version=8 --java_runtime_version=8"

function publish_maven_remote() {
maven_repo_url=$1
Expand All @@ -41,7 +42,8 @@ function publish_maven_remote() {
--define gpg_sign=true \
--define "maven_user=$maven_user" \
--define "maven_password=$maven_password" \
$PUBLISH_TARGET
$PUBLISH_TARGET \
$JDK8_FLAGS
done

}
Expand Down Expand Up @@ -78,6 +80,6 @@ else
echo "Pushing to local Maven repository $local_maven_repo"
for PUBLISH_TARGET in "${ALL_TARGETS[@]}"
do
bazel run --define "maven_repo=file://$local_maven_repo" $PUBLISH_TARGET
bazel run --define "maven_repo=file://$local_maven_repo" $PUBLISH_TARGET $JDK8_FLAGS
done
fi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.