Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Deprecate enableUnsignedLong option. Remove associated base interpreter tests. #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Dec 4, 2024
Merged

Deprecate enableUnsignedLong option. Remove associated base interpreter tests. #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions 4 common/src/main/java/dev/cel/common/CelOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,11 @@ public abstract static class Builder {
/**
* Use {@code UnsignedLong} values to represent unsigned integers within CEL instead of the
* nearest Java equivalent of {@code Long}.
*
* @deprecated Do not use. This option is enabled by default in the currently supported feature
* set {@link CelOptions#DEFAULT}. This flag will be removed in the future.
*/
@Deprecated
public abstract Builder enableUnsignedLongs(boolean value);

/**
Expand Down
6 changes: 2 additions & 4 deletions 6 testing/src/main/java/dev/cel/testing/BaseInterpreterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,8 @@ private static CelOptions.Builder newBaseOptions() {
/** Test options to supply for interpreter tests. */
protected enum InterpreterTestOption {
ADAPT_TYPE_VALUE(newBaseOptions().adaptRuntimeTypeValueToNativeType(true).build(), true),
CEL_TYPE_SIGNED_UINT(newBaseOptions().enableUnsignedLongs(false).build(), true),
CEL_TYPE_UNSIGNED_UINT(newBaseOptions().enableUnsignedLongs(true).build(), true),
PROTO_TYPE_SIGNED_UINT(newBaseOptions().enableUnsignedLongs(false).build(), false),
PROTO_TYPE_UNSIGNED_UINT(newBaseOptions().enableUnsignedLongs(true).build(), false),
CEL_TYPE(newBaseOptions().build(), true),
PROTO_TYPE(newBaseOptions().build(), false),
;

public final CelOptions celOptions;
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.