Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove the legacy createInterpretable(CheckedExpr) #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Nov 12, 2024
+0 −21
Merged

Remove the legacy createInterpretable(CheckedExpr) #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions 2 runtime/src/main/java/dev/cel/runtime/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ java_library(
],
deps = [
":runtime_helper",
"//:auto_value",
"//common",
"//common:error_codes",
"//common:options",
Expand Down Expand Up @@ -85,7 +84,6 @@ java_library(
"//common:error_codes",
"//common:features",
"//common:options",
"//common:proto_ast",
"//common:runtime_exception",
"//common/annotations",
"//common/ast",
Expand Down
8 changes: 0 additions & 8 deletions 8 runtime/src/main/java/dev/cel/runtime/DefaultInterpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

package dev.cel.runtime;

import dev.cel.expr.CheckedExpr;
import dev.cel.expr.Value;
import com.google.auto.value.AutoValue;
import com.google.common.base.Preconditions;
Expand All @@ -24,7 +23,6 @@
import dev.cel.common.CelAbstractSyntaxTree;
import dev.cel.common.CelErrorCode;
import dev.cel.common.CelOptions;
import dev.cel.common.CelProtoAbstractSyntaxTree;
import dev.cel.common.annotations.Internal;
import dev.cel.common.ast.CelConstant;
import dev.cel.common.ast.CelExpr;
Expand Down Expand Up @@ -122,12 +120,6 @@ public DefaultInterpreter(
this.celOptions = celOptions;
}

@Override
@Deprecated
public Interpretable createInterpretable(CheckedExpr checkedExpr) {
return createInterpretable(CelProtoAbstractSyntaxTree.fromCheckedExpr(checkedExpr).getAst());
}

@Override
public Interpretable createInterpretable(CelAbstractSyntaxTree ast) {
return new DefaultInterpretable(typeProvider, dispatcher, ast, celOptions);
Expand Down
11 changes: 0 additions & 11 deletions 11 runtime/src/main/java/dev/cel/runtime/Interpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

package dev.cel.runtime;

import dev.cel.expr.CheckedExpr;
import javax.annotation.concurrent.ThreadSafe;
import dev.cel.common.CelAbstractSyntaxTree;
import dev.cel.common.annotations.Internal;
Expand All @@ -28,16 +27,6 @@
@Internal
public interface Interpreter {

/**
* Creates an interpretable for the given expression.
*
* <p>This method may run pre-processing and partial evaluation of the expression it gets passed.
*
* @deprecated Use {@link #createInterpretable(CelAbstractSyntaxTree)} instead.
*/
@Deprecated
Interpretable createInterpretable(CheckedExpr checkedExpr) throws InterpreterException;

/**
* Creates an interpretable for the given expression.
*
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.