Replace call to proto2::Arena::Destroy with delete.#1785
Merged
Merged
Replace call to proto2::Arena::Destroy with delete.#1785
proto2::Arena::Destroy with delete.#1785Conversation
d40ea3e to
8e90f03
Compare
`Arena::Destroy` conditionally `delete`s the pointer if it was not allocated on an arena, but in this branch of the code we know the object was not allocated on an arena, making the check redundant. PiperOrigin-RevId: 831010142
8e90f03 to
b48a3b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace call to
proto2::Arena::Destroywithdelete.Arena::Destroyconditionallydeletes the pointer if it was not allocated on an arena, but in this branch of the code we know the object was not allocated on an arena, making the check redundant.