Drop const qualification on built cel::Runtime.#1773
Merged
Merged
Drop const qualification on built cel::Runtime.#1773
Conversation
2d39753 to
51cb879
Compare
Const qualification doesn't help much here and makes working with the type a bit awkward in some cases. Added some comments on cases that can cause problems. PiperOrigin-RevId: 827551632
51cb879 to
c274678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop const qualification on built cel::Runtime.
Const qualification doesn't help much here and makes working with the type
a bit awkward in some cases. Added some comments on cases that can cause problems.