Make BaseActivation class move-constructible/assignable#164
Merged
Merged
Make BaseActivation class move-constructible/assignable#164
Conversation
TristonianJones
approved these changes
Mar 8, 2023
Collaborator
|
@tyxia do you also need this change backported to a specific release branch as well? |
Contributor
Author
I think not but let me confirm with @kyessenov, do you think we need this change in any specific release branch if Envoy want to use it? Thanks |
Collaborator
|
Envoy usually uses at head, but I don't remember if we synced the heads together. |
Contributor
Author
Thanks Kuat. @TristonianJones I think we are good for now. I will reach out if we need the help from your end. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy constructor/assignment are explicitly deleted. These user-defined function will also delete implicitly-declared move constructor/assignment, which make this class not move-constructible/assignable.
Bring them back by adding =default move constructor/assignment.
Also, change default destructor to use
=defaultwhich is suggested by style guide.