Update the spec test suite submodule - #8805
#8805Merged
alexcrichton merged 3 commits intoJun 14, 2024
bytecodealliance:mainbytecodealliance/wasmtime:mainfrom
alexcrichton:update-spec-testsuite-submodulealexcrichton/wasmtime:update-spec-testsuite-submoduleCopy head branch name to clipboard
Merged
Update the spec test suite submodule#8805alexcrichton merged 3 commits intobytecodealliance:mainbytecodealliance/wasmtime:mainfrom alexcrichton:update-spec-testsuite-submodulealexcrichton/wasmtime:update-spec-testsuite-submoduleCopy head branch name to clipboard
alexcrichton merged 3 commits into
bytecodealliance:mainbytecodealliance/wasmtime:mainfrom
alexcrichton:update-spec-testsuite-submodulealexcrichton/wasmtime:update-spec-testsuite-submoduleCopy head branch name to clipboard
Conversation
* Ignore the `memory64` tests since Wasmtime doesn't implement the table64 extension yet. * Ignore `gc/i31.wast` as it's got new tests which Wasmtime doesn't currently pass.
fitzgen
approved these changes
Jun 14, 2024
Comment on lines
+81
to
+84
| // Wasmtime doesn't implement the table64 extension yet. | ||
| if part == "memory64" { | ||
| return true; | ||
| } |
Member
There was a problem hiding this comment.
It seems a bit surprising that we have to ignore all memory64 tests now and not just the table related ones. Is the latter possible?
alexcrichton
enabled auto-merge
June 14, 2024 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memory64tests since Wasmtime doesn't implement the table64 extension yet.gc/i31.wastas it's got new tests which Wasmtime doesn't currently pass.