Cranelift: VeriISLE: type check terms in isolation, fix over-constraints - #13998
#13998Open
avanhatt wants to merge 1 commit into
bytecodealliance:mainbytecodealliance/wasmtime:mainfrom
avanhatt:veri-spec-type-checkavanhatt/wasmtime:veri-spec-type-checkCopy head branch name to clipboard
Open
Cranelift: VeriISLE: type check terms in isolation, fix over-constraints#13998avanhatt wants to merge 1 commit intobytecodealliance:mainbytecodealliance/wasmtime:mainfrom avanhatt:veri-spec-type-checkavanhatt/wasmtime:veri-spec-type-checkCopy head branch name to clipboard
avanhatt wants to merge 1 commit into
bytecodealliance:mainbytecodealliance/wasmtime:mainfrom
avanhatt:veri-spec-type-checkavanhatt/wasmtime:veri-spec-type-checkCopy head branch name to clipboard
Conversation
…s it finds. Adds a check that builds verification conditions for one term at a time, against nothing but its own declared types, so that a genuine type conflict is distinct from an expansion that shouldn't be reached for a specific type. Fixes the conflicts it reports.
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type check term specs in isolation, and fix the over-constrained specs it finds.
Adds a check that type-checks verification conditions for each term used in an ISLE compilation one at a time, against nothing but its own declared types, so that a genuine type conflict is distinct from an expansion that shouldn't be reached for a specific type.
The one gnarly case is the spec for
aarch64MInst.MovFromVec: becauseaarch64does not have separateRegtypes for distinct sizes, it's difficult to faithfully model 128-bit-registers via ouraslpautomatically generated specs. Adds a special case to onlyspecthe low 64-bits of the register and leave the top unconstrained (sound, but incomplete).