Fixed repeated paths from incorrectly incrementing data offset. - #215
#215Merged
buger merged 1 commit intoNov 24, 2020
buger:masterbuger/jsonparser:masterfrom
rrgilchrist:fix-repeat-pathsCopy head branch name to clipboard
Merged
Fixed repeated paths from incorrectly incrementing data offset.#215buger merged 1 commit intobuger:masterbuger/jsonparser:masterfrom rrgilchrist:fix-repeat-pathsCopy head branch name to clipboard
buger merged 1 commit into
buger:masterbuger/jsonparser:masterfrom
rrgilchrist:fix-repeat-pathsCopy head branch name to clipboard
Conversation
Author
|
PS: Nice fast parser BTW. |
Owner
|
Nice, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR fixes a bug where repeated path matches incorrectly increment the data offset. Existing unit tests were modified and failed before applying the fix.