Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: add missing MCP node definition to workflow schema#128

Merged
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
fix/add-mcp-node-schema-definitionbreaking-brake/cc-wf-studio:fix/add-mcp-node-schema-definitionCopy head branch name to clipboard
Nov 21, 2025
Merged

fix: add missing MCP node definition to workflow schema#128
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
fix/add-mcp-node-schema-definitionbreaking-brake/cc-wf-studio:fix/add-mcp-node-schema-definitionCopy head branch name to clipboard

Conversation

@breaking-brake
Copy link
Copy Markdown
Owner

@breaking-brake breaking-brake commented Nov 21, 2025

Problem

AI-assisted workflow generation was failing when trying to create MCP nodes with validation errors:

Current Behavior

  1. User requests AI to generate workflow with MCP nodes
  2. ❌ AI generates MCP node with incorrect structure due to missing schema definition
  3. ❌ Validation fails with errors:
    • MCP_INVALID_PARAMETERS: Parameters must be an array
    • MCP_INVALID_MODE: Invalid mode 'specificTool' (valid: manualParameterConfig, aiParameterConfig, aiToolSelection)

Expected Behavior

  1. User requests AI to generate workflow with MCP nodes
  2. ✅ AI references MCP node schema definition
  3. ✅ AI generates correct MCP node structure
  4. ✅ Validation passes and workflow is created successfully

Solution

Added complete MCP node type definition to workflow-schema.json to guide AI generation, and added commit message guidelines to prevent overly complex commit messages in the future.

Changes

File: resources/workflow-schema.json

  • Added "mcp" to supportedNodeTypes array
  • Added comprehensive nodeTypes.mcp definition with:
    • Required fields: serverId, toolName, validationStatus, outputPorts
    • Optional fields: toolDescription, parameters, parameterValues, mode
    • Field constraints:
      • parameters: Must be array of parameter schema objects [{name, type, description, required}]
      • mode: Must be one of manualParameterConfig, aiParameterConfig, aiToolSelection
    • AI generation guidance section with:
      • Explicit instructions to use manualParameterConfig mode
      • Parameter structure examples
      • Common tool names for popular MCP servers (Playwright, GitHub, Filesystem)
      • Complete working example

File: CLAUDE.md

  • Added commit message guidelines section
  • Emphasizes simple commit messages for squash merge workflow
  • Conventional Commits format with 3-5 bullet points max
  • Clear examples of what to avoid (long explanations, code blocks, test results)

Impact

  • UX: AI workflow generation now correctly handles MCP nodes without validation errors
  • Breaking Change: None - additive changes only
  • Side Effects: None - existing workflows are unaffected
  • Schema Size: 16KB → 21KB (~5KB increase from MCP definition)

Testing

  • Manual E2E testing completed
    • Created workflow with MCP (Playwright) nodes via AI generation
    • Verified no MCP_INVALID_PARAMETERS or MCP_INVALID_MODE errors
    • Confirmed correct node structure generated with proper parameters array and mode field
  • Code quality checks passed
    • npm run format && npm run lint && npm run check
    • npm run build succeeded

Notes

  • Known Limitation: AI may generate non-existent tool names (e.g., tools not available in installed MCP servers). Tracked in Add validation for MCP tool names in AI-generated workflows #129 for future enhancement with runtime tool name validation.
  • This fix unblocks AI-assisted workflow generation for MCP integration demos and README hero image creation.

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

@breaking-brake breaking-brake force-pushed the fix/add-mcp-node-schema-definition branch from c2de781 to e3d33b6 Compare November 21, 2025 13:46
- Added 'mcp' to supportedNodeTypes
- Added complete MCP node type definition with field constraints
- Fixes MCP_INVALID_PARAMETERS and MCP_INVALID_MODE validation errors
@breaking-brake breaking-brake force-pushed the fix/add-mcp-node-schema-definition branch from e3d33b6 to 87d5304 Compare November 21, 2025 13:48
@breaking-brake breaking-brake merged commit 14f68ae into main Nov 21, 2025
3 checks passed
github-actions Bot added a commit that referenced this pull request Nov 21, 2025
## [2.11.1](v2.11.0...v2.11.1) (2025-11-21)

### Bug Fixes

* add missing MCP node definition to workflow schema ([#128](#128)) ([14f68ae](14f68ae))
* allow empty parameters for MCP tools without parameters ([#130](#130)) ([f0e52cd](f0e52cd))
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

breaking-brake added a commit that referenced this pull request Nov 23, 2025
- Added 'mcp' to supportedNodeTypes
- Added complete MCP node type definition with field constraints
- Fixes MCP_INVALID_PARAMETERS and MCP_INVALID_MODE validation errors
breaking-brake pushed a commit that referenced this pull request Nov 23, 2025
## [2.11.1](v2.11.0...v2.11.1) (2025-11-21)

### Bug Fixes

* add missing MCP node definition to workflow schema ([#128](#128)) ([14f68ae](14f68ae))
* allow empty parameters for MCP tools without parameters ([#130](#130)) ([f0e52cd](f0e52cd))
@breaking-brake breaking-brake mentioned this pull request Nov 29, 2025
@breaking-brake breaking-brake deleted the fix/add-mcp-node-schema-definition branch December 3, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.