Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: allow empty parameters for MCP tools without parameters#130

Merged
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
fix/allow-empty-mcp-parametersbreaking-brake/cc-wf-studio:fix/allow-empty-mcp-parametersCopy head branch name to clipboard
Nov 21, 2025
Merged

fix: allow empty parameters for MCP tools without parameters#130
breaking-brake merged 1 commit intomainbreaking-brake/cc-wf-studio:mainfrom
fix/allow-empty-mcp-parametersbreaking-brake/cc-wf-studio:fix/allow-empty-mcp-parametersCopy head branch name to clipboard

Conversation

@breaking-brake
Copy link
Copy Markdown
Owner

Problem

MCP tools that have no parameters (e.g., browser_snapshot) were failing export validation with errors:

  • "Manual parameter config mode requires parameters array to be set"
  • "Manual parameter config mode requires parameterValues to be configured"

Current Behavior

  1. User creates workflow with parameter-less MCP tool (e.g., browser_snapshot)
  2. Node has parameters: [] and parameterValues: {} (valid empty state)
  3. ❌ Export validation fails
  4. ❌ User cannot export workflow to slash commands

Expected Behavior

  1. User creates workflow with parameter-less MCP tool
  2. Node has parameters: [] and parameterValues: {} (valid empty state)
  3. ✅ Export validation passes
  4. ✅ Workflow exports successfully

Solution

Modified validation logic in validate-workflow.ts to allow empty arrays/objects for parameter-less tools.

Changes

File: src/extension/utils/validate-workflow.ts (Lines 427-444)

Before:

if (!mcpData.parameters || mcpData.parameters.length === 0) {
  errors.push({ ... }); // Rejects empty array
}
if (!mcpData.parameterValues || Object.keys(mcpData.parameterValues).length === 0) {
  errors.push({ ... }); // Rejects empty object
}

After:

// Allow empty array for parameter-less tools
if (!mcpData.parameters) {
  errors.push({ ... });
}
// Only check parameterValues if parameters exist
if (mcpData.parameters && mcpData.parameters.length > 0) {
  if (!mcpData.parameterValues || Object.keys(mcpData.parameterValues).length === 0) {
    errors.push({ ... });
  }
}

Logic:

  • parameters: [] is now valid (parameter-less tools)
  • parameterValues: {} is valid when parameters is empty
  • parameterValues existence is only checked when parameters has items

Impact

  • UX: Users can now export workflows with parameter-less MCP tools
  • Breaking Change: None - validation is more permissive
  • Side Effects: None - tools with parameters still require values

Testing

  • Manual E2E testing completed
    • Created workflow with browser_snapshot (no parameters)
    • Verified export succeeds with parameters: [] and parameterValues: {}
    • Verified tools with parameters still require values
  • Code quality checks passed
    • npm run format && npm run lint && npm run check
    • npm run build succeeded

Notes

  • This fix enables creation of README hero image workflow using browser_snapshot
  • Export service already handles empty parameters correctly (lines 418-445)
  • Validation was the only blocker

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

- Allow parameters: [] for tools with no parameters
- Allow parameterValues: {} when parameters is empty
- Fixes export validation error for browser_snapshot and similar tools
@breaking-brake breaking-brake merged commit f0e52cd into main Nov 21, 2025
3 checks passed
github-actions Bot added a commit that referenced this pull request Nov 21, 2025
## [2.11.1](v2.11.0...v2.11.1) (2025-11-21)

### Bug Fixes

* add missing MCP node definition to workflow schema ([#128](#128)) ([14f68ae](14f68ae))
* allow empty parameters for MCP tools without parameters ([#130](#130)) ([f0e52cd](f0e52cd))
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

breaking-brake added a commit that referenced this pull request Nov 23, 2025
- Allow parameters: [] for tools with no parameters
- Allow parameterValues: {} when parameters is empty
- Fixes export validation error for browser_snapshot and similar tools
breaking-brake pushed a commit that referenced this pull request Nov 23, 2025
## [2.11.1](v2.11.0...v2.11.1) (2025-11-21)

### Bug Fixes

* add missing MCP node definition to workflow schema ([#128](#128)) ([14f68ae](14f68ae))
* allow empty parameters for MCP tools without parameters ([#130](#130)) ([f0e52cd](f0e52cd))
@breaking-brake breaking-brake mentioned this pull request Nov 29, 2025
@breaking-brake breaking-brake deleted the fix/allow-empty-mcp-parameters branch December 3, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.