Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixed bug with sys.stdin.readline()#909

Closed
TheQu1etOwl wants to merge 1 commit into
bpython:mainbpython/bpython:mainfrom
TheQu1etOwl:mainTheQu1etOwl/bpython:mainCopy head branch name to clipboard
Closed

Fixed bug with sys.stdin.readline()#909
TheQu1etOwl wants to merge 1 commit into
bpython:mainbpython/bpython:mainfrom
TheQu1etOwl:mainTheQu1etOwl/bpython:mainCopy head branch name to clipboard

Conversation

@TheQu1etOwl

Copy link
Copy Markdown

image
I fixed this bug:
image

@codecov-commenter

codecov-commenter commented Aug 22, 2021

Copy link
Copy Markdown

Codecov Report

Merging #909 (fadc1fb) into main (f7d8b77) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
- Coverage   67.93%   67.91%   -0.03%     
==========================================
  Files          61       61              
  Lines        9150     9153       +3     
==========================================
  Hits         6216     6216              
- Misses       2934     2937       +3     
Impacted Files Coverage Δ
bpython/curtsies.py 50.67% <0.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d8b77...fadc1fb. Read the comment docs.

@sebastinas

Copy link
Copy Markdown
Contributor

I fear that this just hides an issue. self.current_stdouterr_line has the wrong time in this case and that should be fixed.

@thomasballinger thomasballinger self-assigned this Oct 7, 2021
thomasballinger added a commit that referenced this pull request Oct 7, 2021
Static types would have helped! I'll add some.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.