Expose fields for subclass.#49
Merged
Merged
Expose fields for subclass.#49
Conversation
Owner
|
Agree, make sense. I did not think about subclasses (I thought its customizable enough) |
bmelnychuk
added a commit
that referenced
this pull request
Jan 22, 2016
Expose fields for subclass.
Owner
|
Will update maven repo tomorrow |
Contributor
Author
|
Hi, has this been updated on maven repo? |
Owner
|
Yes, version 1.2.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The pull request changes are for the following reasons.
I am currently writing a FileTreeView which has the interface
This requires creating a root node before initialising the superclass AndroidTreeView.
mRoot usually needs to be visited in subclasses when writing a custom traverse method. I changed it to protected.
I have the need to access the nodeContainer from others classes.
For example, I want to set the background of a single row to a certain colour.
This would colour all the children nodes.
Instead, I would like to do something like this: