Lorem ipsum generator#333
Merged
bislara merged 6 commits intoOct 28, 2021
bislara:masterbislara/code-n-stitch:masterfrom
atom19-i:lorem-ipsum-generatoratom19-i/code-n-stitch:lorem-ipsum-generatorCopy head branch name to clipboard
Merged
Lorem ipsum generator#333bislara merged 6 commits intobislara:masterbislara/code-n-stitch:masterfrom atom19-i:lorem-ipsum-generatoratom19-i/code-n-stitch:lorem-ipsum-generatorCopy head branch name to clipboard
bislara merged 6 commits into
bislara:masterbislara/code-n-stitch:masterfrom
atom19-i:lorem-ipsum-generatoratom19-i/code-n-stitch:lorem-ipsum-generatorCopy head branch name to clipboard
Conversation
Changes to your CodeSee Architecture Map:View this PR diagram as an interactive map View more CodeSee Maps Legend |
bislara
requested changes
Oct 23, 2021
Owner
There was a problem hiding this comment.
hey Good job @atom19-i
Could you look after the below things:-
- Remove the Mappable Part from this PR. This PR should contain only the files of lorem-ipsum-generator
- lorem-ipsum-generator is added twice, ie it has 2 folders. Remove one of the folders.
- Add the project to the readme present inside the javascript folder https://github.com/bislara/code-n-stitch/blob/master/JavaScript/README.md
Contributor
Author
|
@bislara please review this PR now. I have made the required changes. |
bislara
approved these changes
Oct 28, 2021
|
Thanks very much for contributing! Your pull request has been merged 🎉 Hoping for more contribution from you in future. Happy hacking and Learning ✌🤟 |
Owner
|
@all-contributors please add @atom19-i for code, doc |
Contributor
|
I've put up a pull request to add @atom19-i! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mapable is map based application built using html, css and javascript along with mapbox API. One can find real time traffic details over the route. it can also find the best route between source point and destination point via cycling, walking or driving.
Dependency
none. In addition to this,User can use different access token for mapbox by creating a new account and using their account's token.
Fixes #332
Screenshot
Type of change
Checklist:
README.md