Merged
knet_manager: use KNET helpers for managing KNET interfaces#485
Conversation
KanjiMonster
force-pushed
the
jogo_knet_helpers
branch
from
December 16, 2025 08:57
266076d to
05ccb11
Compare
Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Wire up the newly introduced KNET helper functions in OF-DPA and expose them via sai.h Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Switch the KNET manager to use the newly added helpers for adding and removing KNET interfaces instead of calling client_drivshell. This requires us passing the switch_interface to port mananagers. After that we can now create them directly, which as a side effect also avoids all the log spam while creating. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_knet_helpers
branch
from
January 23, 2026 09:38
05ccb11 to
d192ddf
Compare
KanjiMonster
marked this pull request as ready for review
January 23, 2026 09:39
rubensfig
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use newly introduced KNET helper functions for creating and removing KNET interfaces instead of calling
client_drivshellwith appropriate arguments.This simplifies the creation/removal and allows us to handle extensions in the SDK instead of needing to keep baseboxd in sync.
bisdn/basebox-protobuf#13