Gradient Boosting - Remove try/catch around imports#6584
Draft
PrimozGodec wants to merge 4 commits into
biolab:masterbiolab/orange3:masterfrom
PrimozGodec:boosting-remove-importsPrimozGodec/orange3:boosting-remove-importsCopy head branch name to clipboard
Draft
Gradient Boosting - Remove try/catch around imports#6584PrimozGodec wants to merge 4 commits intobiolab:masterbiolab/orange3:masterfrom PrimozGodec:boosting-remove-importsPrimozGodec/orange3:boosting-remove-importsCopy head branch name to clipboard
PrimozGodec wants to merge 4 commits into
biolab:masterbiolab/orange3:masterfrom
PrimozGodec:boosting-remove-importsPrimozGodec/orange3:boosting-remove-importsCopy head branch name to clipboard
Conversation
PrimozGodec
force-pushed
the
boosting-remove-imports
branch
2 times, most recently
from
September 21, 2023 13:32
130bbcf to
297ec2c
Compare
Member
|
Come on, let's wait a bit with this so that we see if the added requirements create problems for anyone. I am making this a draft. |
markotoplak
marked this pull request as draft
September 21, 2023 17:05
PrimozGodec
marked this pull request as ready for review
January 11, 2024 16:31
Contributor
Author
|
/rebase |
PrimozGodec
force-pushed
the
boosting-remove-imports
branch
from
January 11, 2024 16:49
7ad0e49 to
3364ea4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6584 +/- ##
==========================================
- Coverage 88.07% 88.05% -0.02%
==========================================
Files 322 322
Lines 70254 70226 -28
==========================================
- Hits 61874 61841 -33
- Misses 8380 8385 +5 |
PrimozGodec
marked this pull request as draft
January 11, 2024 17:04
PrimozGodec
force-pushed
the
boosting-remove-imports
branch
from
January 12, 2024 07:39
637f695 to
55f4965
Compare
PrimozGodec
force-pushed
the
boosting-remove-imports
branch
from
January 12, 2024 07:47
dc080ec to
360b7b3
Compare
PrimozGodec
marked this pull request as ready for review
January 12, 2024 07:50
Contributor
Author
|
I think it can be reviewed and merged now. |
Member
|
I'd wait with this a little bit now that newest xgboost version started not packing libomp again. Perhaps we should even think about dropping the requirement... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
After #6570, try/catch around xgboost/catboost methods is not required anymore since packages are always installed
Description of changes
Remove try/catch around imports, skips in tests, and simplify parts of the code.
This PR also fix translations since the check is currently failing on the master.
Includes