Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Bump dependency ciftools-java-jdk8 to 4.0.5#1050

Merged
aalhossary merged 1 commit into
biojava:masterbiojava/biojava:masterfrom
aalhossary:fix_cif_writing_in_non-US_localeaalhossary/biojava:fix_cif_writing_in_non-US_localeCopy head branch name to clipboard
Jan 9, 2023
Merged

Bump dependency ciftools-java-jdk8 to 4.0.5#1050
aalhossary merged 1 commit into
biojava:masterbiojava/biojava:masterfrom
aalhossary:fix_cif_writing_in_non-US_localeaalhossary/biojava:fix_cif_writing_in_non-US_localeCopy head branch name to clipboard

Conversation

@aalhossary

Copy link
Copy Markdown
Member

Bump dependency 4.0.5 to Fix cif writing in non-US locales.

Thanks @JonStargaryen for fixing the bug at ciftools-java.
Fixes #1049.

Bump dependency 4.0.5 to Fix cif writing in non-US locales.
@aalhossary aalhossary requested a review from sbittrich January 9, 2023 02:10

@sbittrich sbittrich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this @aalhossary

@aalhossary aalhossary merged commit 99aae04 into biojava:master Jan 9, 2023
@aalhossary aalhossary deleted the fix_cif_writing_in_non-US_locale branch January 9, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java.lang.NumberFormatException: For input string: "18,623" on TestMMCIFWriting.test1A2C

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.