Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Bioassembly fails for a structure with null seqres groups (MMTF only) #792

Copy link
Copy link
Closed
Closed
Bioassembly fails for a structure with null seqres groups (MMTF only)#792
Copy link
Labels
bugBugs and bugfixesBugs and bugfixes

Description

@biocryst
biocryst
opened on Aug 21, 2018
Issue body actions

StructureIO.getStructure("BIO:2X3T:1") causes exception when cloning the asymmetric unit, if MMTF is used (cache.setUseMmtf(true)). The reason is null seqres groups.

There are two issues here: difference in the data between MMTF and MMCIF, and "safe" code.

I can make the code a bit safer, i.e. take this test:

biojava/biojava-structure/src/main/java/org/biojava/nbio/structure/ChainImpl.java

Lines 190 to 193 in 8a7b651

if (seqResGroup==null) {
tmpSeqRes.add(null);
continue;
}

and put a similar one here:

biojava/biojava-structure/src/main/java/org/biojava/nbio/structure/ChainImpl.java

Lines 638 to 643 in 8a7b651

public void setSeqResGroups(List<Group> groups){
for (Group g: groups){
g.setChain(this);
}
this.seqResGroups = groups;
}

I am not sure what to do with the difference in the data at this point.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugBugs and bugfixesBugs and bugfixes

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
    Morty Proxy This is a proxified and sanitized view of the page, visit original site.