Add support for including the query string#2
Add support for including the query string#2briandela wants to merge 1 commit into
Conversation
|
Is there a compelling reason why it would ever be omitted? Not including it was pure oversight on my part. |
|
As it is today it's not included. Essentially, I didn't want to make the new default behaviour a breaking change. |
There was a problem hiding this comment.
Didn't know if/how you wanted this filled in so I left it blank for now. Can fill it in with details as needed.
|
I could just change the default to include it - it's a lot smaller change :-) Only one line. |
|
I'd actually prefer to brainstorm any other breaking changes and roll them out in a 2.0 that gets things right. An option to disable qs inclusion is a non-breaking change after that but I'd rather not include an option if there's not a good reason. |
|
I did just update this PR to be the 1 liner fix before I saw your response. |
|
Awesome! Released as 1.0.1 since not passing the query string was a bug. |
Adds an option which allows for having the redirect include the query string.