Use ArrayBuffers instead of Node Buffer#40
Draft
Use ArrayBuffers instead of Node Buffer#40
Conversation
ca6e0b9 to
4654f51
Compare
Contributor
|
| 📦 Package | 📋 Versions |
|---|---|
| escape-string-regexp | 3 versions
|
💡 To find out what depends on a specific package, run: pnpm -r why example-package
⚠️ Package Size Increase
| 📦 Package | 📏 Base Size | 📏 Source Size | 📈 Size Change |
|---|---|---|---|
| binary-util | 5.2 kB | 5.2 kB | +6 B |
2ddfcfd to
446d28f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr uses arraybuffers instead of node's buffers for the operations, allowing browser usage.
im not sure if this is a good idea, i want to at least benchmark both versions to make sure its not ungodly slower
having benchmarked, decoding using buffer is 1.7x faster than using arraybuffers. in browsers it would presumably still be slower with a polyfill