Fix for Solaris10 sh#212
Merged
bsparrow435 merged 1 commit intoFeb 10, 2017
basho:4.0basho/node_package:4.0from
kesslerm:fix/solaris10-nodetool-aliaskesslerm/node_package:fix/solaris10-nodetool-aliasCopy head branch name to clipboard
Merged
Fix for Solaris10 sh#212bsparrow435 merged 1 commit intobasho:4.0basho/node_package:4.0from kesslerm:fix/solaris10-nodetool-aliaskesslerm/node_package:fix/solaris10-nodetool-aliasCopy head branch name to clipboard
bsparrow435 merged 1 commit into
basho:4.0basho/node_package:4.0from
kesslerm:fix/solaris10-nodetool-aliaskesslerm/node_package:fix/solaris10-nodetool-aliasCopy head branch name to clipboard
Conversation
80f4e6a to
cee23ac
Compare
Commit 44a4f19 uses $(command) notation to populate SSL_ARGS. This notation is not supported by Solaris10 sh. Use backticks instead. Ksh expands aliases containing '=' differently from bash, but seems to work fine when an alias is evaluated inside backticks. Call NODETOOL inside backticks consistently throughout the file. As other functions depend on ping_node() returning the exit code from NODETOOL, but CLI users expect to see the stdout output, capture the exit code before echoing the command output.
cee23ac to
65125b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 44a4f19 uses $(command) notation
to populate SSL_ARGS. This notation is not supported by Solaris10 sh.
Use backticks instead.
Ksh expands aliases containing '=' differently from bash, but seems
to work fine when an alias is evaluated inside backticks. Call NODETOOL
inside backticks consistently throughout the file.