Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: include config on new CancelledError - #4922

#4922
Merged
jasonsaayman merged 10 commits into
axios:v1.xaxios/axios:v1.xfrom
arthurfiorette:v1.xCopy head branch name to clipboard
Nov 25, 2022
Merged

fix: include config on new CancelledError#4922
jasonsaayman merged 10 commits into
axios:v1.xaxios/axios:v1.xfrom
arthurfiorette:v1.xCopy head branch name to clipboard

Conversation

@arthurfiorette

Copy link
Copy Markdown
Contributor

Suplement of #4659 and #4711.

Another line of code that throws CanceledError was left behind. :)

@arthurfiorette

Copy link
Copy Markdown
Contributor Author

The CI broke because of what? Do not seems an issue with the 2 parameters I added. Can someone rerun it?

@Legion2

Legion2 commented Sep 10, 2022

Copy link
Copy Markdown

We are getting many errors because config property of AxiosError is undefined in our request interceptors, but according to the typescript definition it is not allowed to be undefined. We think that this is caused by CancelledError which do not include the config property.

@arthurfiorette

Copy link
Copy Markdown
Contributor Author

@jasonsaayman can we get this merged? :)

@arthurfiorette

Copy link
Copy Markdown
Contributor Author

@DigitalBrainJS can you approve this PR?

@arthurfiorette arthurfiorette mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.