Fix TS definition for AxiosRequestTransformer - #4201
#4201Merged
Merged
Fix TS definition for AxiosRequestTransformer#4201
Conversation
The callback `AxiosRequestTransformer` can always expect its `headers` parameter to be defined. This is ensured immediately before the callback is made. See: https://github.com/axios/axios/blob/1025d1231a7747503188459dd5a6d1effdcea928/lib/core/dispatchRequest.js#L32-L40
brianhelba
added a commit
to brianhelba/axios
that referenced
this pull request
Oct 19, 2021
`transformRequest` callbacks can always expect their `headers` parameter to be defined. This is ensured immediately before the callback is made. See: https://github.com/axios/axios/blob/1025d1231a7747503188459dd5a6d1effdcea928/lib/core/dispatchRequest.js#L32-L40 Accordingly, checking whether `headers` is `undefined` is unnecessary. This is related to axios#4201.
Member
|
Thanks for the contribution |
Merged
This was referenced Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callback
AxiosRequestTransformercan always expect itsheadersparameter to be defined. This is ensured immediately before the callback
is made.
See:
axios/lib/core/dispatchRequest.js
Lines 32 to 40 in 1025d12