Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: core methodList, HTTP adapter errors, and add tests#11096

Open
Mohammad-Faiz-Cloud-Engineer wants to merge 1 commit into
axios:v1.xaxios/axios:v1.xfrom
Mohammad-Faiz-Cloud-Engineer:v1.x-recreatedMohammad-Faiz-Cloud-Engineer/axios:v1.x-recreatedCopy head branch name to clipboard
Open

fix: core methodList, HTTP adapter errors, and add tests#11096
Mohammad-Faiz-Cloud-Engineer wants to merge 1 commit into
axios:v1.xaxios/axios:v1.xfrom
Mohammad-Faiz-Cloud-Engineer:v1.x-recreatedMohammad-Faiz-Cloud-Engineer/axios:v1.x-recreatedCopy head branch name to clipboard

Conversation

@Mohammad-Faiz-Cloud-Engineer

@Mohammad-Faiz-Cloud-Engineer Mohammad-Faiz-Cloud-Engineer commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is a recreation of PR #11048 (#11048). I accidentally deleted the branch from my fork, which caused the previous PR to close. Opening this PR again with the same changes.

Changes:

  • **\lib/core/methodList.js**: Centralized HTTP method list for single-source-of-truth.
  • **\lib/core/Axios.js**: Import \methodList; use \methodList.concat('common')\ for \headers\ flattening.
  • **\lib/defaults/index.js**: Import \methodList; use it for \defaults.headers\ initialization.
  • **\lib/adapters/http.js**: Throw \AxiosError\ with \ERR_BAD_OPTION_VALUE\ for invalid address (instead of \TypeError) and invalid/unsupported \httpVersion.
  • **\lib/core/mergeConfig.js**: Fixed key typo \ imeoutMessage\ → \ imeoutErrorMessage.
  • Tests added for methodList header coverage, address/httpVersion validation, and \ imeoutErrorMessage\ merging.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Jul 22, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments
@jasonsaayman jasonsaayman Awaiting requested review from jasonsaayman jasonsaayman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Mohammad-Faiz-Cloud-Engineer
Morty Proxy This is a proxified and sanitized view of the page, visit original site.