removed home module - #323
#323Merged
pkrawat1 merged 1 commit intoJan 15, 2019
developaviabird/angularspree:developfrom
refactor/remove-home-module-dependencyaviabird/angularspree:refactor/remove-home-module-dependencyCopy head branch name to clipboard
Merged
removed home module#323pkrawat1 merged 1 commit intodevelopaviabird/angularspree:developfrom refactor/remove-home-module-dependencyaviabird/angularspree:refactor/remove-home-module-dependencyCopy head branch name to clipboard
pkrawat1 merged 1 commit into
developaviabird/angularspree:developfrom
refactor/remove-home-module-dependencyaviabird/angularspree:refactor/remove-home-module-dependencyCopy head branch name to clipboard
Conversation
pkrawat1
added a commit
that referenced
this pull request
Sep 20, 2023
### Why? - There is no need of home module after new search module. ### This change addresses the need by :- - Removing home module dependencies from entire app. - Removing home module. - Connecting home module search dispatcher to search module dispatchers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
This change addresses the need by :-