Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Adjust time doctest that had out-of-date numbers [docs only]#9636

Merged
bsipocz merged 1 commit into
astropy:masterastropy/astropy:masterfrom
mhvk:time-doc-test-adjustmentmhvk/astropy:time-doc-test-adjustmentCopy head branch name to clipboard
Nov 19, 2019
Merged

Adjust time doctest that had out-of-date numbers [docs only]#9636
bsipocz merged 1 commit into
astropy:masterastropy/astropy:masterfrom
mhvk:time-doc-test-adjustmentmhvk/astropy:time-doc-test-adjustmentCopy head branch name to clipboard

Conversation

@mhvk

@mhvk mhvk commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

fixes #9627

@pllim

This comment has been minimized.

@mhvk
mhvk force-pushed the time-doc-test-adjustment branch from 9659d3b to 63e7e10 Compare November 19, 2019 22:03
@mhvk

mhvk commented Nov 19, 2019

Copy link
Copy Markdown
Contributor Author

Darn, a git commit -a too quickly done... Now fixed.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. I wonder why Travis CI didn't catch it. Is it because of the caching? If it is the cache, then if Travis CI fails, someone needs to clear cache and rerun this.

I'll give @bsipocz a chance to look as well.

@bsipocz

bsipocz commented Nov 19, 2019

Copy link
Copy Markdown
Member

Perfect, thanks @mhvk!

@bsipocz
bsipocz merged commit 3a99493 into astropy:master Nov 19, 2019
@mhvk
mhvk deleted the time-doc-test-adjustment branch November 20, 2019 01:08
bsipocz added a commit that referenced this pull request Dec 1, 2019
Adjust time doctest that had out-of-date numbers [docs only]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: doctest failure with v4.0rc1

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.