Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

TST: Skip segfault test case instead of xfail#8160

Merged
astrofrog merged 1 commit into
astropy:masterastropy/astropy:masterfrom
pllim:lim-segfault-fixpllim/astropy:lim-segfault-fixCopy head branch name to clipboard
Nov 20, 2018
Merged

TST: Skip segfault test case instead of xfail#8160
astrofrog merged 1 commit into
astropy:masterastropy/astropy:masterfrom
pllim:lim-segfault-fixpllim/astropy:lim-segfault-fixCopy head branch name to clipboard

Conversation

@pllim

@pllim pllim commented Nov 19, 2018

Copy link
Copy Markdown
Member

Fix #8148

I am very perplexed on why this only happens to me. But given that this particular test has a known recursion problem, it really does not matter whether we skip or xfail, but unfortunately the latter gives me seg fault.

@astropy-bot

astropy-bot Bot commented Nov 19, 2018

Copy link
Copy Markdown

Hi there @pllim 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@codecov

codecov Bot commented Nov 19, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8160   +/-   ##
=======================================
  Coverage   86.92%   86.92%           
=======================================
  Files         383      383           
  Lines       57860    57860           
  Branches     1056     1056           
=======================================
  Hits        50296    50296           
  Misses       6950     6950           
  Partials      614      614
Impacted Files Coverage Δ
astropy/logger.py 79.32% <0%> (-0.43%) ⬇️
astropy/samp/hub.py 77.52% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afe2af...1b5c3c4. Read the comment docs.

@astrofrog
astrofrog merged commit 392d36b into astropy:master Nov 20, 2018
@pllim
pllim deleted the lim-segfault-fix branch November 20, 2018 19:00
bsipocz pushed a commit that referenced this pull request Nov 23, 2018
TST: Skip segfault test case instead of xfail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.