[ty] Expand test suite for assignment errors - #24537
#24537Merged
sharkdp merged 1 commit intoApr 10, 2026
mainastral-sh/ruff:mainfrom
david/invalid-assignment-extend-testsastral-sh/ruff:david/invalid-assignment-extend-testsCopy head branch name to clipboard
Merged
[ty] Expand test suite for assignment errors#24537sharkdp merged 1 commit intomainastral-sh/ruff:mainfrom david/invalid-assignment-extend-testsastral-sh/ruff:david/invalid-assignment-extend-testsCopy head branch name to clipboard
sharkdp merged 1 commit into
mainastral-sh/ruff:mainfrom
david/invalid-assignment-extend-testsastral-sh/ruff:david/invalid-assignment-extend-testsCopy head branch name to clipboard
Conversation
sharkdp
commented
Apr 10, 2026
Comment on lines
+334
to
+356
| ## Assigning an overload set | ||
|
|
||
| This test makes sure that error context from failed overload candidates does not leak | ||
| (`IncompatibleFoo.bar` is assignable to `SupportsFooAndBar.bar`): | ||
|
|
||
| ```py | ||
| from typing import Protocol, overload, SupportsIndex | ||
|
|
||
| class SupportsFooAndBar(Protocol): | ||
| def foo(self, name: str): ... | ||
| def bar(self, x: bytes): ... | ||
|
|
||
| class IncompatibleFoo: | ||
| def foo(self, name_: str): ... | ||
| @overload | ||
| def bar(self, x: SupportsIndex): ... | ||
| @overload | ||
| def bar(self, x: bytes): ... | ||
| def bar(self, x: SupportsIndex | bytes): ... | ||
|
|
||
| def _(source: IncompatibleFoo): | ||
| target: SupportsFooAndBar = source # error: [invalid-assignment] | ||
| ``` |
Contributor
Author
There was a problem hiding this comment.
This is a bit convoluted, but was important in tracking down a problem during the implementation. It originates from a real world case but was minified/altered a lot.
sharkdp
commented
Apr 10, 2026
Comment on lines
+361
to
+364
| from collections.abc import Iterable | ||
|
|
||
| def _(source: list[str]): | ||
| target: Iterable[bytes] = source # error: [invalid-assignment] |
Contributor
Author
There was a problem hiding this comment.
This case is interesting because it probably makes sense to (eventually) add a special cased hint instead of printing an error tree like:
info: type `list[str]` is not compatible with protocol `Iterable[bytes]`
info: └── protocol member `__iter__` is incompatible
info: └── incompatible return types `Iterator[str]` and `Iterator[bytes]`
info: └── type `Iterator[str]` is not compatible with protocol `Iterator[bytes]`
info: └── incompatible return types `str` and `bytes`
sharkdp
commented
Apr 10, 2026
| target: bytes | None = source # error: [invalid-assignment] | ||
| ``` | ||
|
|
||
| ## Intersections |
Contributor
Author
There was a problem hiding this comment.
Analogous to the section on unions just above.
sharkdp
commented
Apr 10, 2026
| target: SupportsCheck = source # error: [invalid-assignment] | ||
| ``` | ||
|
|
||
| Missing protocol properties: |
Contributor
Author
There was a problem hiding this comment.
This test case is important because missing protocol members are detected using a fast path, and so they are handled differently from incompatible protocol members (above).
sharkdp
commented
Apr 10, 2026
|
|
||
| ```py | ||
| def _(source: int): | ||
| target: str | bytes | bool | None = source # error: [invalid-assignment] |
Contributor
Author
There was a problem hiding this comment.
This is a boring case of a union assignment failure where we probably don't want to add any additional context. Just telling you that int is not assignable to str | bytes | bool | None is enough — no breakdown needed.
sharkdp
marked this pull request as ready for review
April 10, 2026 11:37
sharkdp
requested review from
AlexWaygood,
carljm,
dcreager and
ibraheemdev
as code owners
April 10, 2026 11:37
AlexWaygood
approved these changes
Apr 10, 2026
carljm
added a commit
that referenced
this pull request
Apr 10, 2026
* main: [ty] Fix bad diagnostic range for incorrect implicit `__init_subclass__` calls (#24541) [ty] Add a `SupportedPythonVersion` enum (#24412) [ty] Ignore unsupported editor-selected Python versions (#24498) [ty] Add snapshots for `__init_subclass__` diagnostics (#24539) [ty] Minor fix in tests (#24538) [ty] Allow `Final` variable assignments in `__post_init__` (#24529) [ty] Expand test suite for assignment errors (#24537) [ty] Use `map`, not `__map`, as the name of the mapping parameter in `TypedDict` `__init__` methods (#24535) [ty] Rework logic for synthesizing `TypedDict` methods (#24534) [flake8-bandit] Fix S103 false positives and negatives in mask analysis (#24424) [ty] mdtest.py: update dependencies (#24533) Rename patterns and arguments source order iterator method (#24532) [ty] Omit invalid keyword arguments from `TypedDict` signature (#24522) [ty] support super() in metaclass methods (#24483) [ty] Synthesize `__init__` for `TypedDict` (#24476)
carljm
added a commit
that referenced
this pull request
Apr 10, 2026
* main: Bump typing conformance suite commit to latest upstream (#24553) [ty] Reject deleting`Final` attributes (#24508) [ty] Respect property deleters in attribute deletion checks (#24500) [ty] stop unioning Unknown into types of un-annotated attributes (#24531) [ty] Fix bad diagnostic range for incorrect implicit `__init_subclass__` calls (#24541) [ty] Add a `SupportedPythonVersion` enum (#24412) [ty] Ignore unsupported editor-selected Python versions (#24498) [ty] Add snapshots for `__init_subclass__` diagnostics (#24539) [ty] Minor fix in tests (#24538) [ty] Allow `Final` variable assignments in `__post_init__` (#24529) [ty] Expand test suite for assignment errors (#24537) [ty] Use `map`, not `__map`, as the name of the mapping parameter in `TypedDict` `__init__` methods (#24535) [ty] Rework logic for synthesizing `TypedDict` methods (#24534) [flake8-bandit] Fix S103 false positives and negatives in mask analysis (#24424) [ty] mdtest.py: update dependencies (#24533) Rename patterns and arguments source order iterator method (#24532) [ty] Omit invalid keyword arguments from `TypedDict` signature (#24522) [ty] support super() in metaclass methods (#24483) [ty] Synthesize `__init__` for `TypedDict` (#24476)
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pulling out some new (snapshot) test cases from #24309 to make that easier to review.
The current output in the snapshots is completely boring but will change soon.