🦋 Changeset detected

Latest commit: a3e8ff8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Claude finished @Kinfe123's task in 2m 17s —— View job

Review — PR #5080 (through a3e8ff8)

Changes since last review

One commit, a3e8ff8, which applies the previously suggested refactor verbatim: streamedArgsText is resolved before the predicate, and isStreamingArglessChunk now explicitly requires streamed text to be absent, so the flag's truth value matches its name in every state rather than relying on its position in the ?? chain.

Previously identified issues — all resolved

Correctness

The fix targets the right root cause. The tracker enforces a prefix-monotonic contract on argsText (packages/core/src/runtimes/tool-invocations/ToolInvocationTracker.ts:638 — content.argsText.startsWith(entry.argsText)), so a first snapshot of "{}" permanently rejects every later prefix like '{"url":'. Emitting "" for the argless first frame is the uniquely safe value: every string starts with "".

I also confirmed the fix only affects the path that was actually broken. The messages-tuple accumulator (appendLangChainChunk.ts:10) already synthesizes partial_json: "" for an argless first chunk, so that path never hit the stringify fallback; the bug lived in the messages/partial path where the server sends full snapshots with tool_calls + tool_call_chunks and no partial_json — exactly what the new tests model.

Tests & repo requirements

• Both regression tests are well-targeted: the Bedrock first-frame → partial-args sequence (prefix monotonicity) and the retained-argless-chunk-with-completed-args case (the earlier greptile regression). Fixtures match the real messages/partial wire shape.
• Changeset present (@assistant-ui/react-langgraph, patch) ✅
• No public API surface change, so no api-reference regen needed ✅
• CI: all runs green (the one cancelled Changeset Semver Check was superseded by a successful re-run). I couldn't execute the test suite locally in this sandbox (command approval), so I'm relying on the green PR #5080 CI run.

Good practices

• Regression tests model the exact provider wire shape from the issue, both directions of the ambiguity.
• Review feedback applied as focused, single-purpose commits.

Simplify

The simplify agent surfaced one candidate: the streamedArgsText === undefined clause is technically redundant at the ternary's only use site (the ternary is reached only when chunk.partial_json ?? streamedArgsText is nullish), so predicate and ternary could collapse back into the ?? chain. I'm deliberately not requesting this — it would reverse the decoupling applied in a3e8ff8, whose point was that the flag's truth value shouldn't depend on chain position. The current form is the right trade. No other reuse, efficiency, or simplification issues found.

Verdict: LGTM. The fix is minimal, root-caused, tested from both directions, and all prior review threads are resolved.

_{Reviews (1): Last reviewed commit: "fix(react-langgraph): preserve streamed ..." | Re-trigger Greptile}