Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Dec 16, 2023. It is now read-only.

Added support for passing-through client cert and key - #99

#99
Merged
assaf merged 3 commits into
assaf:masterassaf/node-replay:masterfrom
gzurbach:cert-supportgzurbach/node-replay:cert-supportCopy head branch name to clipboard
Oct 19, 2017
Merged

Added support for passing-through client cert and key#99
assaf merged 3 commits into
assaf:masterassaf/node-replay:masterfrom
gzurbach:cert-supportgzurbach/node-replay:cert-supportCopy head branch name to clipboard

Conversation

@gzurbach

@gzurbach gzurbach commented May 25, 2016

Copy link
Copy Markdown
Contributor

I spent the last two days struggling to get a test using certificates working with node-replay.

The following snippet shows where my test was failing:

var options = {
  key: certificate.privateKey,
  cert: certificate.certificate,
  // more stuff
}

var request = https.request(options, function(response) { 
  // getting a 403 with node-replay, but 200 when running the app
});

The change in this PR allowed me to fix my test. The test runs with both node 0.10 and 4.4.

These options are listed here: https://nodejs.org/api/https.html#https_https_request_options_callback (see the last example at the bottom of the page).

Please let me know if I am using the wrong approach. Great library btw! :)

@gzurbach gzurbach mentioned this pull request May 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.