Merged
fix(images): hide UFS images from the catalog#157
Conversation
UFS images come through with format "sd" but storage "ufs": they're raw provisioning images without a GPT, meant for QDL/firehose, so writing one to an SD card just produces a non-booting card. Drop them from the listing until QDL UFS flashing is wired up.
🧪 Test BuildsVersion:
ℹ️ About these builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Qualcomm boards like the Radxa Dragon Q6A, UFS images showed up in the catalog and could be flashed, but writing one to an SD card just produced a non-booting card.
The API returns them with format "sd" while marking them storage "ufs": they're raw provisioning images without a GPT, meant for QDL/firehose rather than a block device. The catalog filter only looked at the format and ignored the storage field, so they slipped through.
The listing now also drops images whose storage is UFS, leaving only the SD-flashable variants. They'll come back once QDL UFS flashing is wired up.