rockchip64 & meson64: bump edge to stable 7.1 - #9980
#9980rockchip64 & meson64: bump edge to stable 7.1#9980
Conversation
CONFIG_POWER_RESET_MESON64 has a pending PR rtl8723ds via patch is only needed for rockchip64 family other can use mainline driver other changes are automated
…d 7.2 RTL8192EU still needs attention for 7.1
📝 WalkthroughWalkthroughBumps ChangesKernel 7.1/7.2 Bump for meson64 and rockchip64
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
config/kernel/linux-rockchip64-edge.config (1)
3430-3432:⚠️ Potential issue | 🟠 MajorAdd
CONFIG_GPIO_CDEV_V1=yto align with meson64-edge kernel 7.1 configuration.Both rockchip64-edge and meson64-edge target Linux kernel 7.1, but rockchip64-edge is missing
CONFIG_GPIO_CDEV_V1=ywhich is present in meson64-edge. This inconsistency should be resolved.Add to config/kernel/linux-rockchip64-edge.config
CONFIG_MEMTEST=y +CONFIG_GPIO_CDEV_V1=y🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@config/kernel/linux-rockchip64-edge.config` around lines 3430 - 3432, The rockchip64-edge kernel configuration is missing the CONFIG_GPIO_CDEV_V1=y option that is present in the meson64-edge configuration, causing an inconsistency between the two kernel 7.1 target configurations. Add the line CONFIG_GPIO_CDEV_V1=y to the rockchip64-edge config file to align with the meson64-edge kernel 7.1 configuration and ensure consistency across both targets.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@config/kernel/linux-rockchip64-edge.config`:
- Around line 3430-3432: The rockchip64-edge kernel configuration is missing the
CONFIG_GPIO_CDEV_V1=y option that is present in the meson64-edge configuration,
causing an inconsistency between the two kernel 7.1 target configurations. Add
the line CONFIG_GPIO_CDEV_V1=y to the rockchip64-edge config file to align with
the meson64-edge kernel 7.1 configuration and ensure consistency across both
targets.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f0065901-4bc5-4cac-9f4a-cb9bbc2f4034
📒 Files selected for processing (5)
config/kernel/linux-meson64-edge.configconfig/kernel/linux-rockchip64-edge.configconfig/sources/families/include/meson64_common.incconfig/sources/families/include/rockchip64_common.incconfig/sources/mainline-kernel.conf.sh
|
✅ This PR has been reviewed and approved — all set for merge! |
Description
CONFIG_POWER_RESET_MESON64: meson64: driver-power-meson64-reset.patch breaks compilation on kernel 7.1 #9777How Has This Been Tested?
Checklist:
Summary by CodeRabbit