Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update radxa-e54c.conf - fix netplan ethenet wan port. - #9918

#9918
Merged
schwar3kat merged 2 commits into
armbian:mainarmbian/build:mainfrom
schwar3kat:mainschwar3kat/armbian-build:mainCopy head branch name to clipboard
Jun 1, 2026
Merged

Update radxa-e54c.conf - fix netplan ethenet wan port.#9918
schwar3kat merged 2 commits into
armbian:mainarmbian/build:mainfrom
schwar3kat:mainschwar3kat/armbian-build:mainCopy head branch name to clipboard

Conversation

@schwar3kat

@schwar3kat schwar3kat commented Jun 1, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

The Radxa E54C exposes interfaces lan1, lan2, lan3 and wan. The Armbian netplan config uses a match pattern "wan[0-9]*" which does not match the bare interface name "wan" so replace with "wan" if the 10-dhcp-all-interfaces.yaml file exists (only in netplan builds).

How Has This Been Tested?

  • Tested on Radxa E54C minimal (Netplan)
  • Tested on Radxa E54C Gnome (NetworkManager)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Summary by CodeRabbit

  • Bug Fixes

    • Fixed WAN interface naming on Radxa E54C boards so network configuration now normalizes WAN identifiers, improving connectivity stability and preventing interface naming issues.

  • Chores

    • Minor formatting tweaks to board configuration files for consistency.

@schwar3kat
Update radxa-e54c.conf - fix netplan ethenet wan port.
7f6e4c5 
The Radxa E54C exposes interfaces lan1, lan2, lan3 and wan.   The Armbian netplan config uses a match pattern "wan[0-9]*" which does not match the bare interface name "wan" so replace with "wan" if the 10-dhcp-all-interfaces.yaml file exists (only in netplan builds).
@coderabbitai

coderabbitai Bot commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 502dac84-d11f-4f39-8949-4756564c4a03

📥 Commits

Reviewing files that changed from the base of the PR and between 7f6e4c5 and b359f4f.

📒 Files selected for processing (1)
  • config/boards/radxa-e54c.conf
🚧 Files skipped from review as they are similar to previous changes (1)
  • config/boards/radxa-e54c.conf
📝 Walkthrough

Walkthrough

This PR updates the Radxa E54C board configuration by adding a post-debootstrap hook that normalizes WAN interface naming in netplan (replacing numbered WAN names with wan) and normalizes a comment indentation in the existing LED setup block.

Changes

Radxa E54C Board Configuration

Layer / File(s) Summary
WAN interface naming fix and LED comment cleanup
config/boards/radxa-e54c.conf		 Adds post_post_debootstrap_tweaks__radxa_e54c_wan_fix() which edits ${SDCARD}/etc/netplan/10-dhcp-all-interfaces.yaml to replace wan[0-9]* with wan when the file exists; also normalizes a comment line in the LED enable function.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit nibbles lines of code,
Tweaks WAN names along the road,
One tidy comment, one replace,
Netplan’s neat in its new place,
Radxa hums — a quiet ode. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the radxa-e54c configuration to fix a netplan ethernet wan port issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added 08 Milestone: Third quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Jun 1, 2026
coderabbitai[bot]
coderabbitai Bot reviewed Jun 1, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/boards/radxa-e54c.conf`:
- Line 82: The sed invocation uses an unquoted
${SDCARD}/etc/netplan/10-dhcp-all-interfaces.yaml which can break on spaces/glob
characters; update the sed call that currently reads "sed -i
's/wan\[0-9\]\*/wan/g' ${SDCARD}/etc/netplan/10-dhcp-all-interfaces.yaml" to
quote the target path (e.g. sed -i 's/wan\[0-9\]\*/wan/g'
"${SDCARD}/etc/netplan/10-dhcp-all-interfaces.yaml") so the ${SDCARD} expansion
is treated as a single filename and not subject to word-splitting or globbing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fec84fc2-fab4-4faf-8325-ee068f782784

📥 Commits

Reviewing files that changed from the base of the PR and between 68409a3 and 7f6e4c5.

📒 Files selected for processing (1)
  • config/boards/radxa-e54c.conf

Comment thread config/boards/radxa-e54c.conf Outdated
@schwar3kat
schwar3kat requested review from a team and kamilsaigol June 1, 2026 03:34
@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label Jun 1, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label Jun 1, 2026
@schwar3kat
schwar3kat merged commit 05895f6 into armbian:main Jun 1, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@EvilOlaf EvilOlaf EvilOlaf approved these changes
@kamilsaigol kamilsaigol Awaiting requested review from kamilsaigol

Assignees

No one assigned

Labels

08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@schwar3kat @EvilOlaf
Morty Proxy This is a proxified and sanitized view of the page, visit original site.