Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Treat imx93 as slow hardware - #323

#323
Merged
igorpecovnik merged 1 commit into
armbian:mainarmbian/armbian.github.io:mainfrom
schmiedelm:mainschmiedelm/armbian.github.io:mainCopy head branch name to clipboard
Jun 2, 2026
Merged

Treat imx93 as slow hardware#323
igorpecovnik merged 1 commit into
armbian:mainarmbian/armbian.github.io:mainfrom
schmiedelm:mainschmiedelm/armbian.github.io:mainCopy head branch name to clipboard

Conversation

@schmiedelm

@schmiedelm schmiedelm commented Jun 1, 2026

Copy link
Copy Markdown
Member

generate_targets: disable fast for imx93

@schmiedelm
generate_targets: disable fast for imx93
c17fd46 
Signed-off-by: Martin Schmiedel <Martin.Schmiedel@tq-group.com>
@github-actions github-actions Bot added size/small PR with less then 50 lines 08 Milestone: Third quarter release Needs review Seeking for review labels Jun 1, 2026
@coderabbitai

coderabbitai Bot commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR modifies the is_fast_hardware function in scripts/generate_targets.py to explicitly classify the imx93 boardfamily as slow hardware. The change adds a conditional check that returns False for boards in the imx93 family, overriding any other classification logic. This directs the downstream YAML generation process to categorize these boards into slow-HDMI target lists, affecting which desktop environment targets they match (e.g., XFCE instead of GNOME).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately describes the core change: disabling the fast hardware flag for imx93 in generate_targets, which aligns with the code modifications.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The PR title 'Treat imx93 as slow hardware' directly and accurately describes the main change: classifying imx93 as slow hardware in the board classification logic.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@schmiedelm schmiedelm changed the title use FXCE as default for imx93 Treat imx93 as slow hardware Jun 2, 2026
@igorpecovnik
igorpecovnik merged commit b1b403a into armbian:main Jun 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

08 Milestone: Third quarter release Needs review Seeking for review size/small PR with less then 50 lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@schmiedelm @igorpecovnik
Morty Proxy This is a proxified and sanitized view of the page, visit original site.