HOTFIX runner-clean: only clear proxy env, never set it to acng (fixes datacenter runners) - #25
#25Merged
igorpecovnik merged 1 commit intoJun 28, 2026
mainarmbian/actions:mainfrom
fix/runner-clean-proxy-clear-onlyarmbian/actions:fix/runner-clean-proxy-clear-onlyCopy head branch name to clipboard
Merged
HOTFIX runner-clean: only clear proxy env, never set it to acng (fixes datacenter runners)#25igorpecovnik merged 1 commit intomainarmbian/actions:mainfrom fix/runner-clean-proxy-clear-onlyarmbian/actions:fix/runner-clean-proxy-clear-onlyCopy head branch name to clipboard
igorpecovnik merged 1 commit into
mainarmbian/actions:mainfrom
fix/runner-clean-proxy-clear-onlyarmbian/actions:fix/runner-clean-proxy-clear-onlyCopy head branch name to clipboard
Conversation
… address Regression from the previous change: setting http(s)_proxy to the runner's apt_proxy forced acng (10.0.40.2:3142) as the GENERIC proxy on datacenter runners. acng only proxies apt, so all general HTTPS (ghcr.io, github.com) broke -> builds failed on geekom/etc. Correct behaviour: only blank a stale http(s)_proxy when the runner advertises NO apt proxy (the original leak fix); leave proxied runners untouched (apt uses APT_PROXY_ADDR, git uses git_proxy). The acng address must never become the generic http(s)_proxy. Signed-off-by: Igor Pecovnik <igor@armbian.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Urgent — fixes regression from #24
#24 set
http_proxy/https_proxyto the runner'sapt_proxywhen present. Butapt_proxyis apt-cacher-ng (10.0.40.2:3142), which only proxies apt. Forcing it as the generic proxy on datacenter runners (geekom, …) routed all HTTPS (ghcr.io, github.com) through acng → everything broke:Fix
Clear-only. Blank
http(s)_proxyonly when the runner advertises noapt_proxy(the original leak fix for kspace/insanisfiction). Runners that do advertise a proxy are left completely untouched — apt usesAPT_PROXY_ADDR, git usesgit_proxy. The acng address must never become the generichttp(s)_proxy.Restores datacenter runners to their pre-#24 behaviour while still neutralizing the stale-http_proxy leak on proxy-less runners. Please merge ASAP — #24 is currently breaking builds on every proxied runner.