Fix ast-id-only IR debug info output - #16734
#16734Open
LeviofCrypto wants to merge 1 commit into
argotorg:developargotorg/solidity:developfrom
LeviofCrypto:fix-ast-id-only-ir-debug-infoLeviofCrypto/solidity:fix-ast-id-only-ir-debug-infoCopy head branch name to clipboard
Open
Fix ast-id-only IR debug info output#16734LeviofCrypto wants to merge 1 commit intoargotorg:developargotorg/solidity:developfrom LeviofCrypto:fix-ast-id-only-ir-debug-infoLeviofCrypto/solidity:fix-ast-id-only-ir-debug-infoCopy head branch name to clipboard
LeviofCrypto wants to merge 1 commit into
argotorg:developargotorg/solidity:developfrom
LeviofCrypto:fix-ast-id-only-ir-debug-infoLeviofCrypto/solidity:fix-ast-id-only-ir-debug-infoCopy head branch name to clipboard
Conversation
Contributor
|
Hi @LeviofCrypto , thanks for the PR. /// @use-src 0:"input.sol"
object "C_6_deployed" {
code {
/// @src 0:60:101 "contract C {..."
mstore(64, 128)
}
}
|
| pragma solidity >=0.0; | ||
|
|
||
| contract C { | ||
| function f() public {} |
Contributor
There was a problem hiding this comment.
f() is optimized out in the irOptimized output. It would be interesting to have a more complex function that can show in the optmized output.
| solAssert(_location.sourceName, ""); | ||
| _context.markSourceUsed(*_location.sourceName); | ||
|
|
||
| if (!_context.debugInfoSelection().location) |
Contributor
There was a problem hiding this comment.
This PR also needs a Changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
settings.debug.debugInfo: ["ast-id"]still emitted@srccomments in generated IR because the shared source-location helper treated any non-empty debug info selection as a location request. Skip location comment creation unless thelocationcomponent is selected, while preserving@ast-idoutput.Adds a Standard JSON cmdline test for the ast-id-only IR/EVM assembly output case.
Checklist
AI Disclosure
OpenAI Codex assisted with reviewing the change.