Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat!: run on Node 24 runtime and upgrade dependencies#208

Merged
Voziv merged 2 commits into
mainargocd-diff-action/argocd-diff-action:mainfrom
worktree-dependency-upgradesargocd-diff-action/argocd-diff-action:worktree-dependency-upgradesCopy head branch name to clipboard
May 23, 2026
Merged

feat!: run on Node 24 runtime and upgrade dependencies#208
Voziv merged 2 commits into
mainargocd-diff-action/argocd-diff-action:mainfrom
worktree-dependency-upgradesargocd-diff-action/argocd-diff-action:worktree-dependency-upgradesCopy head branch name to clipboard

Conversation

@Voziv

@Voziv Voziv commented May 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Upgrade all dependencies to their latest versions: @actions/github, @eslint/js (10), eslint (10), globals (17), @types/sinon (21), sinon (22), pre-commit (2), semantic-release (25), typescript (6).
  • Move the action runtime from node20 to node24 and align .nvmrc + @types/node (pinned to 24.x) to match. The dev toolchain already required Node ≥ 22.13 (pnpm 11.2.2, semantic-release 25), so .nvmrc: 20 was stale.
  • Remove three dead eslint dependencies — eslint-plugin-github, eslint-plugin-import and @eslint/eslintrc. None were imported by eslint.config.mjs (eslint-plugin-import was registered but had no active import/* rules), and dropping them clears the eslint 10 peer-dependency warnings with no change to lint behaviour.
  • Closes Upgrade fetch-mock 12.x #175 — fetch-mock is already on the latest 12.x with the v12 API migration complete.

@types/node is intentionally held at 24.x (not 25) to match the runtime; dependabot's existing "ignore @types/node major" rule keeps it pinned there. dist/ is left untouched — it is regenerated by the release workflow.

BREAKING CHANGE

The action now runs on the Node 24 runtime instead of Node 20. It requires a runner with Node 24 available. GitHub-hosted runners provide it; self-hosted runners must have Node 24 installed or the action will fail to start.

Test plan

  • pnpm run lint passes (eslint 10)
  • pnpm run build succeeds (ncc + typescript 6)
  • pnpm run test — 27/28 pass; the one failure (lib.test.ts shell-error assertion) is pre-existing and environment-specific (local /bin/sh is bash, not dash) and passes on CI/Ubuntu
  • CI Checks workflow green on this PR

Voziv added 2 commits May 23, 2026 16:42
Bump to latest: @actions/github, @eslint/js (10), eslint (10),
globals (17), @types/sinon (21), sinon (22), pre-commit (2),
semantic-release (25), typescript (6). Align @types/node to the
Node 24 runtime.

Remove eslint-plugin-github, eslint-plugin-import and @eslint/eslintrc:
none were imported by eslint.config.mjs (eslint-plugin-import was
registered with no active import/* rules), so dropping them clears the
eslint 10 peer-dependency warnings without changing lint behaviour.
Switch the action runtime from node20 to node24 and bump .nvmrc to
match. Update CLAUDE.md references accordingly.

BREAKING CHANGE: the action now requires a runner with Node 24
available. GitHub-hosted runners provide it; self-hosted runners
must have Node 24 installed.
@github-actions

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 88.39% 137/155
🟡 Branches 77.61% 52/67
🟢 Functions 91.18% 31/34
🟢 Lines 88.31% 136/154

Test suite run success

28 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from bacdfa1

@Voziv
Voziv merged commit 13477ad into main May 23, 2026
6 checks passed
@Voziv
Voziv deleted the worktree-dependency-upgrades branch May 23, 2026 20:45
argocd-diff-action-bot Bot pushed a commit that referenced this pull request May 24, 2026
## [0.6.12](0.6.11...0.6.12) (2026-05-24)

### ⚠ BREAKING CHANGES

* run on Node 24 runtime and upgrade dependencies (#208)

### Build & Dependencies

* **deps-dev:** upgrade pnpm to 11.2.2 ([#207](#207)) ([f69a1e6](f69a1e6))

### Documentation

* add CLAUDE.md ([664ab77](664ab77))

### Features

* run on Node 24 runtime and upgrade dependencies ([#208](#208)) ([13477ad](13477ad)), closes [#175](#175)

### Bug Fixes

* use dynamic timezone abbreviation in PR comment timestamp ([#209](#209)) ([81f8e40](81f8e40))

[skip release]
@argocd-diff-action-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.6.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade fetch-mock 12.x

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.