Don’t print “Starts:” label on underscore course tiles of self-paced …#31
Don’t print “Starts:” label on underscore course tiles of self-paced …#31grozdanowski merged 3 commits intoficus/masterappsembler/edx-theme-codebase:ficus/masterfrom feature/fix-underscore-tiles-self-paced-coursesappsembler/edx-theme-codebase:feature/fix-underscore-tiles-self-paced-coursesCopy head branch name to clipboard
Conversation
OmarIthawi
left a comment
There was a problem hiding this comment.
Thanks @grozdanowski! Please address the localization issue.
OmarIthawi
left a comment
There was a problem hiding this comment.
LGTM, but I've only checked the code. I assume that you've tested it 🤷♂️
Thanks @grozdanowski! Hope you don't hate me for the long lines now 🙈
|
@OmarIthawi "was missing a curly bracket :/" commit was the result of a test. It's tested :D Merging. |
|
@grozdanowski I deployed to production for JFrog and we still see "Starts: Now" on the course cards on the /courses page. At least X-Ray Essentials on Prem is a self-paced course. The "Now" is the course start date override from the advanced settings. JFrog uses |
Don’t print “Starts:” label on underscore course tiles of self-paced courses. Ugh. Underscore templates.
Note: needs to be merged into