Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

revert last changes#1418

Open
VladyslavTy wants to merge 2 commits into
mainappsembler/edx-platform:mainfrom
vladyslav/hide-html-elements-in-iframeappsembler/edx-platform:vladyslav/hide-html-elements-in-iframeCopy head branch name to clipboard
Open

revert last changes#1418
VladyslavTy wants to merge 2 commits into
mainappsembler/edx-platform:mainfrom
vladyslav/hide-html-elements-in-iframeappsembler/edx-platform:vladyslav/hide-html-elements-in-iframeCopy head branch name to clipboard

Conversation

@VladyslavTy

Copy link
Copy Markdown

Change description

Revert changes made for login flow

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@VladyslavTy
VladyslavTy requested a review from daniilly August 28, 2024 13:32
@github-actions

Copy link
Copy Markdown

Checking git merge conflicts against https://github.com/openedx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 304
Current conflicts 301
Summary Resolves 3 existing conflicts. Amazing!
Comparing with master
Benchmark conflicts with main 336
Current conflicts 333
Summary Resolves 3 existing conflicts. Amazing!

1 similar comment
@github-actions

Copy link
Copy Markdown

Checking git merge conflicts against https://github.com/openedx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 304
Current conflicts 301
Summary Resolves 3 existing conflicts. Amazing!
Comparing with master
Benchmark conflicts with main 336
Current conflicts 333
Summary Resolves 3 existing conflicts. Amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.